Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cluster resource actions #3979

Merged
merged 11 commits into from
May 23, 2023
Merged

feat: cluster resource actions #3979

merged 11 commits into from
May 23, 2023

Conversation

topliceanurazvan
Copy link
Member

@topliceanurazvan topliceanurazvan commented May 22, 2023 •
edited

Changes

  • Add cluster resource-specific actions

    • In the drawer as a button
    • In the table as context menu

  • Scale/Restart will be enabled just for kind Deployment

  • Update will be shown only in the Manifest tab

P.S: The Diff action will be added after this issue is closed #3915

Screenshots

image

image

image

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@topliceanurazvan topliceanurazvan marked this pull request as draft May 22, 2023 14:40
@topliceanurazvan topliceanurazvan marked this pull request as ready for review May 23, 2023 07:33
@topliceanurazvan topliceanurazvan mentioned this pull request May 23, 2023
Closed
olensmar
olensmar reviewed May 23, 2023
View reviewed changes
Copy link
Member

@olensmar olensmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add telemetry to all user actions - ie. scaleUp/down, delete, restart, etc..

@topliceanurazvan topliceanurazvan merged commit 1f6f5c5 into main May 23, 2023
2 checks passed
@topliceanurazvan topliceanurazvan deleted the razvantopliceanu/feat/cluster-resource-actions branch May 23, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olensmar olensmar olensmar approved these changes

@devcatalin devcatalin Awaiting requested review from devcatalin devcatalin is a code owner

@mortada-codes mortada-codes Awaiting requested review from mortada-codes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Diff cluster resource against local
2 participants
@topliceanurazvan @olensmar