-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: UI rework validation tab #3981
style: UI rework validation tab #3981
Conversation
…on for checking errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. One thing I've noticed is that the New tools coming up soon
is till taking the full width of the container. You can find it under ValidationCardUpNext
.
Also, it would be nice to still have the cards as full width under 1150px
. You can add a laptopS
constant in device.ts
and use the media for having the cards as full width below that specified resolution. Let us know if you have further questions.
Hey @topliceanurazvan! Okay I will make these changes and then get back. |
Thank you @topliceanurazvan for clearing the doubt! |
Hey @topliceanurazvan I made the changes as you suggested. If anything else please let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🙌🏻
Thank you @topliceanurazvan! This was my first contribution in Monokle. I am looking forward to contribute more. |
This PR addresses the issue of UI rework of Validation tab(3443) for 2.2 (current sprint).
Changes
How to test it
npm run electron:dev
Screenshots
Screen Recording
Checklist