Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: UI rework validation tab #3981

Merged

Conversation

ayushgml
Copy link
Contributor

@ayushgml ayushgml commented May 23, 2023

This PR addresses the issue of UI rework of Validation tab(3443) for 2.2 (current sprint).

Changes

  • The ValidationCard column has been set on a width of 50% with left and right margins as 25% each.
  • The subsection title was removed
  • Regular text block has been added instead with a "Checkout errors" button
  • The route to Validation tab has been added with the same animation

How to test it

  • You can test it by viewing the electron app locally by running npm run electron:dev

Screenshots

Screenshot 2023-05-23 at 6 02 28 PM

Screen Recording

Checklist

  • [ V ] tested locally
  • added new dependencies
  • updated the docs
  • added a test

@ayushgml ayushgml changed the title UI rework validation tab 3443 style: UI rework validation tab #3443 May 24, 2023
@ayushgml ayushgml changed the title style: UI rework validation tab #3443 style: UI rework validation tab May 24, 2023
Copy link
Member

@topliceanurazvan topliceanurazvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. One thing I've noticed is that the New tools coming up soon is till taking the full width of the container. You can find it under ValidationCardUpNext.

image

Also, it would be nice to still have the cards as full width under 1150px. You can add a laptopS constant in device.ts and use the media for having the cards as full width below that specified resolution. Let us know if you have further questions.

@ayushgml
Copy link
Contributor Author

Hey @topliceanurazvan! Okay I will make these changes and then get back.

@ayushgml
Copy link
Contributor Author

ayushgml commented May 24, 2023

I have 1 doubt. There is no device.ts file that is showing in the codebase. Should i make one? If yes then in what is the location?
If not then I have added the media query for cards as max-width: 1150px.

Screenshot here

@topliceanurazvan
Copy link
Member

It is a file name, you can search for it inside vs code by pressing ctrl/cmd + p. This should be the content of it:

image

@ayushgml
Copy link
Contributor Author

Thank you @topliceanurazvan for clearing the doubt!

@ayushgml
Copy link
Contributor Author

Hey @topliceanurazvan I made the changes as you suggested. If anything else please let me know.

Screenshot 2023-05-24 at 3 21 08 PM

@topliceanurazvan topliceanurazvan self-requested a review May 24, 2023 10:29
Copy link
Member

@topliceanurazvan topliceanurazvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🙌🏻

@topliceanurazvan topliceanurazvan merged commit 5207766 into kubeshop:main May 24, 2023
1 check passed
@ayushgml
Copy link
Contributor Author

Thank you @topliceanurazvan! This was my first contribution in Monokle. I am looking forward to contribute more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants