fix: add modal confirms when transferring in compare #3985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topliceanurazvan
requested review from
devcatalin,
mortada-codes and
olensmar
as code owners
olensmar
reviewed
May 24, 2023
| Modal.confirm({ | ||
| title: `Are you sure you want to ${transferTo === 'cluster' ? 'deploy to cluster' : 'extract to local'}?`, | ||
| onOk() { | ||
| dispatch(transferResource({ids: [id], direction})); |
There was a problem hiding this comment.
telemetry here? include the transferTo and number of resources if possible?
olensmar
reviewed
May 24, 2023
| Modal.confirm({ | ||
| title: `Are you sure you want to ${buttonLabel.toLowerCase()}?`, | ||
| onOk() { | ||
| dispatch(transferResource({ids, direction})); |
|
We already have telemetry in place for this, it's inside the compare slice, under
|
|
ok thanks - I think we should strive to do telemetry as close to the user action as possible (and not in slices) so we can see where users are performing actions - but we don't have to change this now - just keep in mind for future telemetry! |
olensmar
approved these changes
May 24, 2023
topliceanurazvan
deleted the
razvantopliceanu/fix/replace-action-popup-confirm
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Checklist