Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive space accordion #4015

Merged
merged 6 commits into from
May 30, 2023

Conversation

ayushgml
Copy link
Contributor

This PR addresses the issue:

Changes

  • I added the following in ant-collapse-item-active (Panel) :
display: flex;
flex-direction: column;
justify-content: space-between;

How to test it

  • Run the Electron app and go to the ExplorerPane

Screenshots

Screenshot 2023-05-29 at 4 01 37 PM

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@ayushgml
Copy link
Contributor Author

Hey @topliceanurazvan! I made the necessary changes. Please suggest any changes if you encounter any issues.

@topliceanurazvan topliceanurazvan linked an issue May 29, 2023 that may be closed by this pull request
Copy link
Member

@topliceanurazvan topliceanurazvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we are still missing some padding from the bottom of the pane:

image

Expected:

image

The rest of the work looks good! 🙌🏻

@ayushgml
Copy link
Contributor Author

Okay @topliceanurazvan I will fix this padding issue!

@ayushgml
Copy link
Contributor Author

@topliceanurazvan I made the change! The padding issue was happening only when FilesPane was selected and padding was there when other panes were selected. This was because FilesPane has a slightly different structure than the rest of them. Rest of them have lists which are made using the styled component ListContainer. FilesPane didn't have it so i removed the extra height only when the FilesPane is selected.

This issue issue might be due to the height miscalculation in the AccordionPanel:
const height = usePaneHeight() - PANEL_HEADER_HEIGHT - 130 - (props.panelKey === 'files' ? 35 : 25);

Though I fixed the issue!🙌🏼 You can test it out from your end.

@topliceanurazvan topliceanurazvan self-requested a review May 30, 2023 06:25
Copy link
Member

@topliceanurazvan topliceanurazvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👍🏻

@topliceanurazvan topliceanurazvan merged commit 24ccc06 into kubeshop:main May 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

excessive space between accordion sections
2 participants