Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validation listeren when starting a preview + make thunks #4016

Merged
merged 2 commits into from
May 29, 2023
Merged

fix: validation listeren when starting a preview + make thunks #4016

merged 2 commits into from
May 29, 2023

Conversation

topliceanurazvan
Copy link
Member

Changes

  • Make start/stop/restart previews as thunks

Fixes

  • Running validation listener on starting/stopping/restarting a preview

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@topliceanurazvan topliceanurazvan linked an issue May 29, 2023 that may be closed by this pull request
Previewing a kustomization breaks validation #3988
Closed
olensmar
olensmar previously approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@olensmar olensmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@topliceanurazvan topliceanurazvan merged commit 00b45de into main May 29, 2023
2 checks passed
@topliceanurazvan topliceanurazvan deleted the razvantopliceanu/fix/previews-validation branch May 29, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olensmar olensmar olensmar approved these changes

@devcatalin devcatalin Awaiting requested review from devcatalin devcatalin is a code owner

@mortada-codes mortada-codes Awaiting requested review from mortada-codes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Previewing a kustomization breaks validation
2 participants
@topliceanurazvan @olensmar