Resource name to lowercase #4045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushgml
requested review from
devcatalin,
topliceanurazvan,
mortada-codes and
olensmar
as code owners
topliceanurazvan
requested changes
Jun 7, 2023
| <S.ErrorText> | ||
| <S.ReadMoreLink | ||
| onClick={() => { | ||
| window.open('https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names'); |
There was a problem hiding this comment.
Let's use shell.openExternal instead of window.open
There was a problem hiding this comment.
Done @topliceanurazvan !
|
Roger that!🙌🏼 |
topliceanurazvan
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes:
Changes
VALID_RESOURCE_NAME_REGEXin constantsHow to test it
-Run electron app and try to create a k8s resource with invalid name or namespace or image name.
Screenshots
Checklist