fix: reprocess all resources for file updates #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devcatalin
reviewed
Nov 16, 2021
| } | ||
| }); | ||
|
|
||
| // all existing resources with broken refs (since they might now work) -> this should be improved to |
There was a problem hiding this comment.
good point, should we refactor reprocessResources from services/resource to do a filtering like this instead of checking for all dependent resource kinds and then reprocessing all resources of that kind?
There was a problem hiding this comment.
i was thinking we would add an optional list of targetResourceKinds to the unsatisfied ref (since we know them when we try to discover the ref) - which we could use here for further filtering!?
There was a problem hiding this comment.
actually - looking at the code it seems we already add this to the ref - will see how that works!
There was a problem hiding this comment.
no - this requires more work... will merge this and tackle that separately...
devcatalin
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR...
Changes
Fixes
How to test it
Screenshots
Checklist