feat: Update TestTriggers - Support watching Custom Resource using dynamic informers #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedricmckinnie
requested review from
exu,
nicufk,
vsukhin and
vLia
as code owners
cedricmckinnie
changed the title
|
Some changes in here I don't recognize which I may have accidentally included when syncing with develop branch. Could someone kindly assist with reconciling? Thanks! |
cedricmckinnie
changed the title
|
thank you @cedricmckinnie will reply you tomorrow |
vsukhin
requested changes
Jul 12, 2023
There was a problem hiding this comment.
Thank you, @cedricmckinnie for your efforts. Need to mention a few things:
- Please commit only the changes you did. Kubebuilder generates some stuff, we don't need for CRD, but need for the models
- You will need to copy testtrigger crd changes to helm-chart repo
- Add comments as we did for new fields, they will be passed to CRD
- Technically, you will need to define CustomResource in testkube openapi spec first and generate model based on it. Then copy it to operator, unfortunately, operaotr is not a part of monorepo, so some manual work required
Some small details)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
kubeshop/testkube#3712 (comment)
Testkube API changes: kubeshop/testkube#4161
Checklist (choose whats happened)
Breaking changes
Changes
Fixes