Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support Custom Resource Test Triggers using dynamic informers #4161

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

feat: Support Custom Resource Test Triggers using dynamic informers #4161

wants to merge 21 commits into from

Conversation

cedricmckinnie
Copy link

Pull request description

#3712 (comment)

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

  • updated testkube-operator test-trigger resource to include custom resource GVR as a property for building dynamic informers

Fixes

Cedric McKinnie and others added 20 commits June 29, 2023 14:21
Watch Test,TestSources and TestTriggers from alternate namespaces
c780607
Rename variable
9f1ea7a
Run with multiple namespaces
2465ba7
Optional watch all namespaces
9e7db4f
Support multi-namespace and add TestTrigger support for CustomResources
d7102f7
Add dynamic informers to watch custom resources
021946a
@cedricmckinnie
Merge branch 'kubeshop:main' into main
cf56a6a
Add nats tunnel and port-forward
8c6b7c1
Add GC for informers
322b0fb
Revert "Optional watch all namespaces"
5911ecf 
This reverts commit 9e7db4f.
Revert "Run with multiple namespaces"
c77aab3 
This reverts commit 2465ba7.
Revert "Rename variable"
b86e511 
This reverts commit 9f1ea7a.
Revert "Watch Test,TestSources and TestTriggers from alternate namesp…
3f753d2 
…aces"

This reverts commit c780607.
Merge remote-tracking branch 'origin/main'
49ac4d9
@cedricmckinnie
Merge branch 'kubeshop:main' into main
a7db503
Support custom resources
b418f3c
Prevent UI error
b3d87f4
Merge branch 'main' into support-cr-test-triggers
9b183b0 
# Conflicts:
#	cmd/api-server/main.go
#	internal/config/config.go
#	pkg/triggers/service.go
#	pkg/triggers/watcher.go
#	pkg/triggers/watcher_test.go
Remove watch all namespace flags
0848050
debug statements
7274220
@netlify
Copy link

netlify bot commented Jul 11, 2023 •
edited

✅ Deploy Preview for testkube-docs-preview canceled.

Name Link
🔨 Latest commit 4a3b012
🔍 Latest deploy log https://app.netlify.com/sites/testkube-docs-preview/deploys/64aded59a35d31000847019e

@cedricmckinnie cedricmckinnie mentioned this pull request Jul 11, 2023
Open
6 tasks
@cedricmckinnie cedricmckinnie changed the title Support Custom Resource Test Triggers using dynamic informers Feat: Support Custom Resource Test Triggers using dynamic informers Jul 11, 2023
@cedricmckinnie cedricmckinnie changed the title Feat: Support Custom Resource Test Triggers using dynamic informers feat: Support Custom Resource Test Triggers using dynamic informers Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exu exu Awaiting requested review from exu exu will be requested when the pull request is marked ready for review exu is a code owner

@nicufk nicufk Awaiting requested review from nicufk nicufk will be requested when the pull request is marked ready for review nicufk is a code owner

@vsukhin vsukhin Awaiting requested review from vsukhin vsukhin will be requested when the pull request is marked ready for review vsukhin is a code owner

@vLia vLia Awaiting requested review from vLia vLia will be requested when the pull request is marked ready for review vLia is a code owner

@povilasv povilasv Awaiting requested review from povilasv povilasv will be requested when the pull request is marked ready for review povilasv is a code owner

@dejanzele dejanzele Awaiting requested review from dejanzele dejanzele will be requested when the pull request is marked ready for review dejanzele is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@cedricmckinnie