Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support git@github.com:kubeshop/testkube.git syntax support for cloning repositories #5786

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

rangoo94
Copy link
Member

@rangoo94 rangoo94 commented Aug 28, 2024

Pull request description

  • Added support for git@github.com:kubeshop/testkube.git syntax (by converting it to SSH protocol)
  • Ensure there is newline at EOF in SSH key

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

@rangoo94 rangoo94 requested a review from a team as a code owner August 28, 2024 08:18
@rangoo94 rangoo94 merged commit 14486e2 into develop Aug 29, 2024
10 checks passed
@rangoo94 rangoo94 deleted the dawid/fix/ssh-patterns branch August 29, 2024 07:14
rangoo94 added a commit that referenced this pull request Aug 29, 2024
…cloning repositories (#5786)

* fix: add git@github.com:kubeshop/testkube.git syntax support for cloning URI
* feat: ensure new line on EOF in SSH key
rangoo94 added a commit that referenced this pull request Aug 29, 2024
…cloning repositories (#5786)

* fix: add git@github.com:kubeshop/testkube.git syntax support for cloning URI
* feat: ensure new line on EOF in SSH key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants