fix: add error logging in agent workers (#3325)

* fix: add error logging in agent workers * remove status code validation in core
kubeshop · Oct 31, 2023 · 96ff847 · 96ff847
1 parent 1a827f6
commit 96ff847
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 9 deletions.
diff --git a/agent/client/workflow_listen_for_ds_connection_tests.go b/agent/client/workflow_listen_for_ds_connection_tests.go
@@ -31,7 +31,10 @@ func (c *Client) startDataStoreConnectionTestListener(ctx context.Context) error
 			}
 
 			// TODO: Get ctx from request
-			c.dataStoreConnectionListener(context.Background(), &req)
+			err = c.dataStoreConnectionListener(context.Background(), &req)
+			if err != nil {
+				fmt.Println(err.Error())
+			}
 		}
 	}()
 	return nil

diff --git a/agent/client/workflow_listen_for_poll_requests.go b/agent/client/workflow_listen_for_poll_requests.go
@@ -31,7 +31,10 @@ func (c *Client) startPollerListener(ctx context.Context) error {
 			}
 
 			// TODO: Get ctx from request
-			c.pollListener(context.Background(), &resp)
+			err = c.pollListener(context.Background(), &resp)
+			if err != nil {
+				fmt.Println(err.Error())
+			}
 		}
 	}()
 	return nil

diff --git a/agent/client/workflow_listen_for_trigger_requests.go b/agent/client/workflow_listen_for_trigger_requests.go
@@ -31,7 +31,10 @@ func (c *Client) startTriggerListener(ctx context.Context) error {
 			}
 
 			// TODO: get context from request
-			c.triggerListener(context.Background(), &resp)
+			err = c.triggerListener(context.Background(), &resp)
+			if err != nil {
+				fmt.Println(err.Error())
+			}
 		}
 	}()
 	return nil

diff --git a/agent/client/workflow_shutdown.go b/agent/client/workflow_shutdown.go
@@ -32,7 +32,10 @@ func (c *Client) startShutdownListener(ctx context.Context) error {
 			}
 
 			// TODO: get context from request
-			c.shutdownListener(context.Background(), &resp)
+			err = c.shutdownListener(context.Background(), &resp)
+			if err != nil {
+				fmt.Println(err.Error())
+			}
 		}
 	}()
 	return nil

diff --git a/server/http/mappings/grpc.go b/server/http/mappings/grpc.go
@@ -71,11 +71,6 @@ func (m Model) GRPCRequest(in openapi.GrpcRequest) *trigger.GRPCRequest {
 }
 
 func (m Model) GRPCResponse(in openapi.GrpcResponse) *trigger.GRPCResponse {
-	// ignore unset grcp responses
-	if in.StatusCode == 0 {
-		return nil
-	}
-
 	return &trigger.GRPCResponse{
 		StatusCode: int(in.StatusCode),
 		Metadata:   m.GRPCHeaders(in.Metadata),