-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Selector Language cheat sheet #1392
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ @jorgeepc!
@@ -112,7 +122,7 @@ export const ExpectedInputContainer = styled.div` | |||
outline: 1px solid grey; | |||
height: 32px; | |||
font-family: SFPro, serif; | |||
outline: 1px solid #CDD1DB; | |||
outline: 1px solid #cdd1db; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be coming from the theme?
<S.FormSectionHeaderSelector> | ||
<S.FormSectionRow1> | ||
<S.FormSectionTitle $noMargin>1. Select Spans</S.FormSectionTitle> | ||
<Tag color="blue">{`${spanIdList.length} ${singularOrPlural('span', spanIdList.length)} selected`}</Tag> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like that small singularOrPlural
function lol
This PR adds the Selector Language cheat sheet to the
Create Test Spec
form.Changes
Fixes
Checklist
Screenshot