Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 1401 1 of X goes away when cycling through spans #1423

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Oct 24, 2022

This PR fixes a couple of small issues on the app, primarily the error where the 1 of X component was disappearing when clicking on the arrows from the test mode.
The second one was a wrong flow when clicking show onboarding as it would display the alert instead of starting the onboarding right away.

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@xoscar xoscar linked an issue Oct 24, 2022 that may be closed by this pull request
@xoscar xoscar self-assigned this Oct 24, 2022
@xoscar xoscar marked this pull request as ready for review October 24, 2022 18:34
@xoscar xoscar merged commit 14f0a0b into main Oct 26, 2022
@xoscar xoscar deleted the 1401-1-of-x-goes-away-when-cycling-through-spans branch October 26, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 of X goes away when cycling through spans
2 participants