Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transactions] Integrate resources endpoint in Home page #1457

Merged
merged 8 commits into from
Nov 14, 2022

Conversation

jorgeepc
Copy link
Contributor

@jorgeepc jorgeepc commented Nov 3, 2022

This PR integrates the new /resources endpoint in the Home page. Now we display Tests and Transactions in one single list. It also includes the code to support the list of transaction runs.

Changes

  • Integrate resources endpoint
  • Get transactions runs in home page and transaction page

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Screenshots

Screenshot 2022-11-10 at 13 28 14

Screenshot 2022-11-10 at 13 28 19

@jorgeepc jorgeepc self-assigned this Nov 3, 2022
@jorgeepc jorgeepc marked this pull request as ready for review November 10, 2022 19:48
Copy link
Collaborator

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ my friend!

<TestCard key={test.id} onDelete={onDelete} onRun={handleOnRun} onViewAll={handleOnViewAll} test={test} />
))}
{pagination.list?.map(resource =>
resource.type === ResourceType.test ? (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Factory?

@jorgeepc jorgeepc merged commit 738237e into main Nov 14, 2022
@jorgeepc jorgeepc deleted the 1456-integrate-resources-endpoint branch November 14, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Transactions] Integrate resources endpoint in Home page
2 participants