1458 [Transactions] Edit & Delete implementation for Transactions #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoscar
changed the title
xoscar
commented
Nov 4, 2022
| transaction: TTransaction; | ||
| } | ||
|
|
||
| const EditTransaction = ({transaction}: IProps) => { |
There was a problem hiding this comment.
Basically the same implementation we have for tests
xoscar
commented
Nov 4, 2022
| </S.Title> | ||
| <S.Text>{transaction?.description}</S.Text> | ||
| </div> | ||
| </S.Section> | ||
| <S.Section> | ||
| <TestCardActions testId={transaction?.id || ''} onDelete={noop} /> | ||
| <TestCardActions testId={transaction?.id || ''} onDelete={() => onDelete(transaction.id, transaction.name)} /> |
There was a problem hiding this comment.
adding delete capability
xoscar
commented
Nov 4, 2022
| {items.map((test, index) => ( | ||
| // eslint-disable-next-line react/no-array-index-key | ||
| <TestItem key={`${test.id}-${index}`} test={test} onDelete={onDelete} /> | ||
| {items.map(({id, test}) => ( |
There was a problem hiding this comment.
I found a bug when selecting the same test twice (that is a valid scenario) and the drag & drop, I fixed it by adding an extra unique id
xoscar
commented
Nov 4, 2022
|
|
||
| return ( | ||
| <> | ||
| <TransactionHeader onBack={() => navigate(`/transaction/${transactionId}`)} /> |
There was a problem hiding this comment.
Same layout mechanism as tests
xoscar
commented
Nov 4, 2022
| query: () => `/tests`, | ||
| providesTags: result => [{type: TracetestApiTags.TRANSACTION, id: result?.id}], | ||
| transformResponse: () => TransactionMock.model(), | ||
| transformResponse: () => ({ |
xoscar
deleted the
1458-transactions-edit-delete-implementation-for-transactions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Adds the edit and delete implementation for transactions, it includes the initial designs and wire-up for the transactions run page, similar to what we have for tests, having the edit form and execution results in the same context.
Changes
Fixes
Checklist
https://www.loom.com/share/be52d5887e734e04af480217ee8b45a7