1406 [Transactions] Expected Value Dropdown Selection #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoscar
commented
Nov 4, 2022
| } | ||
|
|
||
| return ds, nil | ||
| return [][]expression.DataStore{ds}, nil |
There was a problem hiding this comment.
Now we are returning an array of strings, this is to cover the scenario where there is no span id in the context and we can return the different resolved values from the selected spans.
xoscar
commented
Nov 4, 2022
| setPrevRawExpression(props.expression || ''); | ||
| }, | ||
| [parseExpressionMutation, prevExpression, prevRawExpression] | ||
| [context, parseExpressionMutation, prevContext, prevExpression, prevRawExpression] |
There was a problem hiding this comment.
Reruns if prev context changes
xoscar
commented
Nov 4, 2022
| > | ||
| <Editor type={SupportedEditors.Expression} placeholder="Expected Value" context={editorContext} /> | ||
| </Form.Item> | ||
| <AssertionCheckValue |
There was a problem hiding this comment.
Moved this to a diff file
xoscar
requested review from
mathnogueira,
jorgeepc and
cescoferraro
and removed request for
mathnogueira
jorgeepc
approved these changes
Nov 7, 2022
| @@ -11,7 +11,7 @@ import OperatorService from 'services/Operator.service'; | |||
| import {TStructuredAssertion} from 'types/Assertion.types'; | |||
| import {singularOrPlural} from 'utils/Common'; | |||
| import AssertionCheckList from './AssertionCheckList'; | |||
| import useAssertionFormValues from './hooks/useAssertionFormValues'; | |||
| // import useAssertionFormValues from './hooks/useAssertionFormValues'; | |||
xoscar
deleted the
1406-transactions-expected-value-dropdown-selection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new feature for the test spec form by displaying a value list dropdown when selecting one of the attributes, it allows users to select with value to add to the expected section from the different selected spans.
Changes
Fixes
Checklist
https://www.loom.com/share/65e7cb843d9e4e108bb3901a1ef7b297