1491 transactions websockets and versioning for transactions #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoscar
requested review from
schoren,
cescoferraro,
jorgeepc and
mathnogueira
Comment on lines
+68
to
+69
| var value model.TransactionRun = *v | ||
| mapped = e.mappers.Out.TransactionRun(value) |
There was a problem hiding this comment.
Can you use this instead?
Suggested change
| var value model.TransactionRun = *v | |
| mapped = e.mappers.Out.TransactionRun(value) | |
| mapped = e.mappers.Out.TransactionRun(*v) |
There was a problem hiding this comment.
I tried that but the TransactionRun function expects a model instance value not a pointer 😢
There was a problem hiding this comment.
Are you sure you tried the exact code as Matheus suggested? It’s the exact same way we’ve done it for test runs, so it should work
xoscar
deleted the
1491-transactions-websockets-and-versioning-for-transactions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the websockets usages from the FE as part of the transaction run page.
Changes
Fixes
Checklist