1505 1475 [Transactions] Display test spec summary results for transaction test runs #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoscar
changed the title
jorgeepc
approved these changes
Nov 16, 2022
| @@ -26,7 +27,7 @@ interface IProps { | |||
| const ExecutionStep = ({ | |||
| index, | |||
| test: {name, trigger, id: testId}, | |||
| testRun: {id: runId, state, testVersion} = TestRun({}), | |||
| testRun: {id: runId, state, testVersion, passedAssertionCount, failedAssertionCount} = TestRun({}), | |||
There was a problem hiding this comment.
Looks great @xoscar I saw in your video that you needed to refresh the page to see the correct results. Is there a problem with the websocket data?
There was a problem hiding this comment.
Yep, problem has been reported to the BE team they are working on it 😄
xoscar
deleted the
1505-transactions-display-test-spec-summary-results-for-transaction-test-runs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the changes to display the results summary for each of the execution steps on the transaction run page.
It allows users to see the passed and failed assertions.
Changes
Fixes
Checklist
https://www.loom.com/share/812f1b3cb17d414f8b48ae55efca65bf