Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve attribute section #1519

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Improve attribute section #1519

merged 1 commit into from
Nov 17, 2022

Conversation

jorgeepc
Copy link
Contributor

This PR implements the new UI for the attribute description popup.

Changes

  • New info icon for attribute description
  • Fix text overflow
  • Fix tags space

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Screenshots

Screenshot 2022-11-17 at 11 26 04

Screenshot 2022-11-17 at 11 26 19

Screenshot 2022-11-17 at 11 26 40

@jorgeepc jorgeepc self-assigned this Nov 17, 2022
@jorgeepc jorgeepc merged commit e9b8cd7 into main Nov 17, 2022
@jorgeepc jorgeepc deleted the 1485-improve-attribute-section branch November 17, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoscar xoscar xoscar approved these changes

@cescoferraro cescoferraro Awaiting requested review from cescoferraro

Assignees

@jorgeepc jorgeepc

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve attribute description section
2 participants
@jorgeepc @xoscar