feat(server): adding event emitter #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbdias
force-pushed
the
add/event-emitter
branch
from
47af86d
to
96ad075
Compare
xoscar
approved these changes
Mar 29, 2023
xoscar
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Clean job @danielbdias I like how you moved the main facade function to a diff file
danielbdias
commented
Mar 29, 2023
| PoolingMaxWaitTimeForTraceDuration() time.Duration | ||
| } | ||
|
|
||
| func newRunnerFacades( |
There was a problem hiding this comment.
I moved to ./server/app/facade.go to keep all concerns about the façade there.
danielbdias
commented
Mar 29, 2023
| } | ||
| } | ||
|
|
||
| func (em *internalEventEmitter) Emit(ctx context.Context, event model.TestRunEvent) error { |
There was a problem hiding this comment.
On the next PRs we can evolve this method to also manage/start trace spans with each phase that we designed.
mathnogueira
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to create an Event Emitter structure inside
./server/executorthat allows us to emit and persist events on Tracetest Server.Changes
Fixes
Checklist