-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): adding event emitter #2269
Merged
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
96ad075
feat(server): adding event emitter
danielbdias 63eed27
Adding more tests to event emitter
danielbdias 6f07106
Fixing unit tests
danielbdias f48baa4
Fix provision file for dev runs
danielbdias 204de2d
Moving EventEmitter to executor package
danielbdias 3c1db70
Fixing dependency injection
danielbdias 1aec5d0
Removing dead code from tests
danielbdias a133b88
Reverted changes in worker
danielbdias File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,6 @@ | ||
dataStore: | ||
--- | ||
type: DataStore | ||
spec: | ||
name: OpenTelemetry Collector | ||
type: otlp | ||
isdefault: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
package event | ||
|
||
import ( | ||
"context" | ||
|
||
"github.com/kubeshop/tracetest/server/model" | ||
) | ||
|
||
type Emitter interface { | ||
Emit(ctx context.Context, event model.TestRunEvent) error | ||
} | ||
|
||
type publisher interface { | ||
Publish(eventID string, message any) | ||
} | ||
|
||
type internalEmitter struct { | ||
repository model.TestRunEventRepository | ||
publisher publisher | ||
} | ||
|
||
func NewEmitter(repository model.TestRunEventRepository, publisher publisher) Emitter { | ||
return &internalEmitter{ | ||
repository: repository, | ||
publisher: publisher, | ||
} | ||
} | ||
|
||
func (em *internalEmitter) Emit(ctx context.Context, event model.TestRunEvent) error { | ||
err := em.repository.CreateTestRunEvent(ctx, event) | ||
if err != nil { | ||
return err | ||
} | ||
|
||
em.publisher.Publish(event.ResourceID(), event) | ||
|
||
return nil | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved to
./server/app/facade.go
to keep all concerns about the façade there.