Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(frontend): adding persistent page number for list #2372

Merged
merged 2 commits into from Apr 12, 2023
Merged

feature(frontend): adding persistent page number for list #2372

merged 2 commits into from Apr 12, 2023

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Apr 12, 2023

This PR updates the behavior of the navigation logic when navigating across different pages, it also keeps track of the page number the list was for so users can come back to what exactly they were looking at.

Changes

  • Updates back buttons for headers to use the goback method
  • Pagination component now updates the search params on page change
  • usePagination hook now checks for a defaultPage from the search params

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

https://www.loom.com/share/7fd3bfc0781d4bfb9e9102dc4e47e0b9

@xoscar xoscar self-assigned this Apr 12, 2023
@xoscar xoscar linked an issue Apr 12, 2023 that may be closed by this pull request
Fix navigation logic #2173
Closed
@xoscar xoscar marked this pull request as ready for review April 12, 2023 17:56
jorgeepc
jorgeepc approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@jorgeepc jorgeepc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💣

@xoscar xoscar merged commit 9fd2329 into main Apr 12, 2023
27 checks passed
@xoscar xoscar deleted the 2173-fix-navigation-logic branch April 12, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeepc jorgeepc jorgeepc approved these changes

@danielbdias danielbdias Awaiting requested review from danielbdias

Assignees

@xoscar xoscar

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix navigation logic
2 participants
@xoscar @jorgeepc