Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 1 of v0.11.3 Doc Updates #2379

Merged
merged 3 commits into from Apr 13, 2023
Merged

Part 1 of v0.11.3 Doc Updates #2379

merged 3 commits into from Apr 13, 2023

Conversation

jfermi
Copy link
Member

@jfermi jfermi commented Apr 13, 2023

Editing and screenshot updates.

This PR...

Changes

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

jfermi and others added 2 commits April 13, 2023 10:16
Copy link
Collaborator

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jfermi this looks great, I added a comment

@@ -25,7 +25,9 @@ You need your SignalFx:

Follow this [guide](https://docs.splunk.com/Observability/references/organizations.html).

![](https://res.cloudinary.com/djwdcmwdz/image/upload/v1674644337/Blogposts/Docs/screely-1674644332529_cks0lw.png)
![SignalFX](../img/SignalFX-settings.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running the npm run build command in the docs folder I get an error about this image being missing, do you mind taking a look?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use it from this file upload?
SignalFX-settings



- Selector
- Selectors
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest version of the app includes an optional name for test specs, not sure if we want to add it here as well

Screenshot 2023-04-13 at 11 21 15

Copy link
Collaborator

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just added a small comment about possibly adding the name as part of the test spec sections

@jfermi jfermi merged commit 7f92f83 into main Apr 13, 2023
1 check passed
@jfermi jfermi deleted the julianne/docs/0.11.3-doc-updates branch April 13, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants