Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve test outputs error handling #2404

Merged
merged 2 commits into from Apr 19, 2023
Merged

feat: improve test outputs error handling #2404

merged 2 commits into from Apr 19, 2023

Conversation

jorgeepc
Copy link
Contributor

@jorgeepc jorgeepc commented Apr 18, 2023 •
edited

This PR adds support for errors in Test Outputs. Now we are including an error icon and message in the list of outputs.

Changes

  • Support for errors in Test Outputs
  • Include the output error as part of the event log

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Screenshot

Screenshot 2023-04-19 at 10 10 02

Loom

https://www.loom.com/share/56c97a5650424e6c9743566378d1be92

@jorgeepc jorgeepc self-assigned this Apr 18, 2023
@jorgeepc jorgeepc force-pushed the 2256-error-handling-test-outputs branch from 7e3d4c4 to 3f1cbf7 Compare April 18, 2023 21:04
@jorgeepc jorgeepc marked this pull request as ready for review April 18, 2023 21:42
xoscar
xoscar approved these changes Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I saw you changed the color for test specs so maybe we should that here, but code looks good 👌🏾 🚢

@jorgeepc jorgeepc merged commit f435b15 into main Apr 19, 2023
28 checks passed
@jorgeepc jorgeepc deleted the 2256-error-handling-test-outputs branch April 19, 2023 16:01
schoren pushed a commit that referenced this pull request Jun 5, 2023
@jorgeepc @schoren
feat: improve test outputs error handling (#2404)
3ca2f02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoscar xoscar xoscar approved these changes

Assignees

@jorgeepc jorgeepc

Labels
backend frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Error Handling] Test section improvements
2 participants
@jorgeepc @xoscar