feat: environments as resources #2415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathnogueira
force-pushed
the
feat/environments-as-resources
branch
from
cb9f7e8
to
4b1910f
Compare
mathnogueira
force-pushed
the
feat/environments-as-resources
branch
3 times, most recently
from
7455c6d
to
2c8f4d6
Compare
* remove old environment endpoints * implement environments as a resource * fix build after rebase * fix encoding * fix test * registering environent resource routes (#2435) * feature(frontend): enabling environments as resources * feature(frontend): fixing unit tests --------- Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com> Co-authored-by: Sebastian Choren <sebastian.choren@gmail.com>
mathnogueira
force-pushed
the
feat/environments-as-resources
branch
from
1b89547
to
d61df7f
Compare
* remove old environment endpoints * feature(frontend): enabling environments as resources (#2437) * remove old environment endpoints * implement environments as a resource * fix build after rebase * fix encoding * fix test * registering environent resource routes (#2435) * feature(frontend): enabling environments as resources * feature(frontend): fixing unit tests --------- Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com> Co-authored-by: Sebastian Choren <sebastian.choren@gmail.com> * fixing unit tests * feature(cli): enabling environments as resources * fixing environments tracetest testing with tracetest * fixing environments tracetest testing with tracetest * fixing environments tracetest testing with tracetest * remove old environment endpoints * implement environments as a resource * fix build after rebase * fix encoding * registering environent resource routes (#2435) * feature(frontend): enabling environments as resources (#2437) * remove old environment endpoints * implement environments as a resource * fix build after rebase * fix encoding * fix test * registering environent resource routes (#2435) * feature(frontend): enabling environments as resources * feature(frontend): fixing unit tests --------- Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com> Co-authored-by: Sebastian Choren <sebastian.choren@gmail.com> * fix rebase * fixing unit tests * fixing environments tracetest testing with tracetest * fixing environments tracetest testing with tracetest * fix rebase * fix test run with env * fix bad rebase --------- Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com> Co-authored-by: Sebastian Choren <sebastian.choren@gmail.com>
xoscar
approved these changes
Apr 28, 2023
|
@schoren @danielbdias CLI and UI changes were reviewed by me and @jorgeepc (feel free to review them if you want). It would be nice to get a review on the server stuff |
danielbdias
approved these changes
Apr 28, 2023
Co-authored-by: Daniel Baptista Dias <danielbdias@users.noreply.github.com>
|
I'll merge it next week |
jorgeepc
approved these changes
May 1, 2023
| @@ -19,7 +19,7 @@ spec: | |||
| In order to apply this configuration to your Tracetest instance, make sure to have your [CLI configured](./configuring-your-cli.md) and run: | |||
|
|
|||
| ``` | |||
| tracetest environment apply -f <environment.yaml> | |||
| tracetest apply environment -f <environment.yaml> | |||
There was a problem hiding this comment.
Is this page part of the docs sidebar? I don't see this page in our docs.
There was a problem hiding this comment.
It was removed by @adnanrahic 5 months ago. I'll ping him to know if that's intentional.
There was a problem hiding this comment.
I think we had an issue with the CLI at some point and I hid the page. I should have put it back in the sidebar eventually. Must have slipped through the cracks.
| return environment, nil | ||
| } | ||
|
|
||
| func (r *Repository) Provision(ctx context.Context, environment Environment) error { |
There was a problem hiding this comment.
With this approach, we can only provision one environment, right?
There was a problem hiding this comment.
No. Each manager provision only one resource at a time. But the provisioner is responsible for reading all resources from the provision YAML file and iterating through them and delegating the provision to this function. So, if there are three environments to be provisioned, this function will be called three times.
schoren
added a commit
that referenced
this pull request
Jun 5, 2023
* remove old environment endpoints * implement environments as a resource * fix build after rebase * fix encoding * fix test * registering environent resource routes (#2435) * feature(frontend): enabling environments as resources (#2437) * remove old environment endpoints * implement environments as a resource * fix build after rebase * fix encoding * fix test * registering environent resource routes (#2435) * feature(frontend): enabling environments as resources * feature(frontend): fixing unit tests --------- Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com> Co-authored-by: Sebastian Choren <sebastian.choren@gmail.com> * add instrumentation to resource manager * Update map conversion logic * fix cli tests * fix rebase * fix span name * fix tests * remove broken middleware config * fix generated file * chore(docs): updating docs * feature(cli): enabling environments as resources (#2446) * remove old environment endpoints * feature(frontend): enabling environments as resources (#2437) * remove old environment endpoints * implement environments as a resource * fix build after rebase * fix encoding * fix test * registering environent resource routes (#2435) * feature(frontend): enabling environments as resources * feature(frontend): fixing unit tests --------- Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com> Co-authored-by: Sebastian Choren <sebastian.choren@gmail.com> * fixing unit tests * feature(cli): enabling environments as resources * fixing environments tracetest testing with tracetest * fixing environments tracetest testing with tracetest * fixing environments tracetest testing with tracetest * remove old environment endpoints * implement environments as a resource * fix build after rebase * fix encoding * registering environent resource routes (#2435) * feature(frontend): enabling environments as resources (#2437) * remove old environment endpoints * implement environments as a resource * fix build after rebase * fix encoding * fix test * registering environent resource routes (#2435) * feature(frontend): enabling environments as resources * feature(frontend): fixing unit tests --------- Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com> Co-authored-by: Sebastian Choren <sebastian.choren@gmail.com> * fix rebase * fixing unit tests * fixing environments tracetest testing with tracetest * fixing environments tracetest testing with tracetest * fix rebase * fix test run with env * fix bad rebase --------- Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com> Co-authored-by: Sebastian Choren <sebastian.choren@gmail.com> * fix instrumentation * fix span name * Apply suggestions from code review Co-authored-by: Daniel Baptista Dias <danielbdias@users.noreply.github.com> * remove empty line --------- Co-authored-by: Sebastian Choren <sebastian.choren@gmail.com> Co-authored-by: Oscar Reyes <oscar-rreyes1@hotmail.com> Co-authored-by: Daniel Dias <danielbpdias@gmail.com> Co-authored-by: Daniel Baptista Dias <danielbdias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts out environment endpoints to use the new resource manager.
Checklist