-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(frontend): enabling environments as resources #2437
Merged
xoscar
merged 9 commits into
feat/environments-as-resources
from
feat/environments-as-resources-frontend
Apr 25, 2023
Merged
feature(frontend): enabling environments as resources #2437
xoscar
merged 9 commits into
feat/environments-as-resources
from
feat/environments-as-resources-frontend
Apr 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as-resources-frontend
jorgeepc
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💥
xoscar
merged commit Apr 25, 2023
17f9cc4
into
feat/environments-as-resources
18 of 20 checks passed
mathnogueira
added a commit
that referenced
this pull request
Apr 27, 2023
* remove old environment endpoints * implement environments as a resource * fix build after rebase * fix encoding * fix test * registering environent resource routes (#2435) * feature(frontend): enabling environments as resources * feature(frontend): fixing unit tests --------- Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com> Co-authored-by: Sebastian Choren <sebastian.choren@gmail.com>
mathnogueira
added a commit
that referenced
this pull request
Apr 27, 2023
* remove old environment endpoints * implement environments as a resource * fix build after rebase * fix encoding * fix test * registering environent resource routes (#2435) * feature(frontend): enabling environments as resources * feature(frontend): fixing unit tests --------- Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com> Co-authored-by: Sebastian Choren <sebastian.choren@gmail.com>
mathnogueira
added a commit
that referenced
this pull request
Apr 27, 2023
* remove old environment endpoints * implement environments as a resource * fix build after rebase * fix encoding * fix test * registering environent resource routes (#2435) * feature(frontend): enabling environments as resources * feature(frontend): fixing unit tests --------- Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com> Co-authored-by: Sebastian Choren <sebastian.choren@gmail.com>
mathnogueira
added a commit
that referenced
this pull request
Apr 27, 2023
* remove old environment endpoints * implement environments as a resource * fix build after rebase * fix encoding * fix test * registering environent resource routes (#2435) * feature(frontend): enabling environments as resources * feature(frontend): fixing unit tests --------- Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com> Co-authored-by: Sebastian Choren <sebastian.choren@gmail.com>
mathnogueira
added a commit
that referenced
this pull request
Apr 27, 2023
* remove old environment endpoints * feature(frontend): enabling environments as resources (#2437) * remove old environment endpoints * implement environments as a resource * fix build after rebase * fix encoding * fix test * registering environent resource routes (#2435) * feature(frontend): enabling environments as resources * feature(frontend): fixing unit tests --------- Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com> Co-authored-by: Sebastian Choren <sebastian.choren@gmail.com> * fixing unit tests * feature(cli): enabling environments as resources * fixing environments tracetest testing with tracetest * fixing environments tracetest testing with tracetest * fixing environments tracetest testing with tracetest * remove old environment endpoints * implement environments as a resource * fix build after rebase * fix encoding * registering environent resource routes (#2435) * feature(frontend): enabling environments as resources (#2437) * remove old environment endpoints * implement environments as a resource * fix build after rebase * fix encoding * fix test * registering environent resource routes (#2435) * feature(frontend): enabling environments as resources * feature(frontend): fixing unit tests --------- Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com> Co-authored-by: Sebastian Choren <sebastian.choren@gmail.com> * fix rebase * fixing unit tests * fixing environments tracetest testing with tracetest * fixing environments tracetest testing with tracetest * fix rebase * fix test run with env * fix bad rebase --------- Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com> Co-authored-by: Sebastian Choren <sebastian.choren@gmail.com>
mathnogueira
added a commit
that referenced
this pull request
May 2, 2023
* remove old environment endpoints * implement environments as a resource * fix build after rebase * fix encoding * fix test * registering environent resource routes (#2435) * feature(frontend): enabling environments as resources (#2437) * remove old environment endpoints * implement environments as a resource * fix build after rebase * fix encoding * fix test * registering environent resource routes (#2435) * feature(frontend): enabling environments as resources * feature(frontend): fixing unit tests --------- Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com> Co-authored-by: Sebastian Choren <sebastian.choren@gmail.com> * add instrumentation to resource manager * Update map conversion logic * fix cli tests * fix rebase * fix span name * fix tests * remove broken middleware config * fix generated file * chore(docs): updating docs * feature(cli): enabling environments as resources (#2446) * remove old environment endpoints * feature(frontend): enabling environments as resources (#2437) * remove old environment endpoints * implement environments as a resource * fix build after rebase * fix encoding * fix test * registering environent resource routes (#2435) * feature(frontend): enabling environments as resources * feature(frontend): fixing unit tests --------- Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com> Co-authored-by: Sebastian Choren <sebastian.choren@gmail.com> * fixing unit tests * feature(cli): enabling environments as resources * fixing environments tracetest testing with tracetest * fixing environments tracetest testing with tracetest * fixing environments tracetest testing with tracetest * remove old environment endpoints * implement environments as a resource * fix build after rebase * fix encoding * registering environent resource routes (#2435) * feature(frontend): enabling environments as resources (#2437) * remove old environment endpoints * implement environments as a resource * fix build after rebase * fix encoding * fix test * registering environent resource routes (#2435) * feature(frontend): enabling environments as resources * feature(frontend): fixing unit tests --------- Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com> Co-authored-by: Sebastian Choren <sebastian.choren@gmail.com> * fix rebase * fixing unit tests * fixing environments tracetest testing with tracetest * fixing environments tracetest testing with tracetest * fix rebase * fix test run with env * fix bad rebase --------- Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com> Co-authored-by: Sebastian Choren <sebastian.choren@gmail.com> * fix instrumentation * fix span name * Apply suggestions from code review Co-authored-by: Daniel Baptista Dias <danielbdias@users.noreply.github.com> * remove empty line --------- Co-authored-by: Sebastian Choren <sebastian.choren@gmail.com> Co-authored-by: Oscar Reyes <oscar-rreyes1@hotmail.com> Co-authored-by: Daniel Dias <danielbpdias@gmail.com> Co-authored-by: Daniel Baptista Dias <danielbdias@users.noreply.github.com>
schoren
added a commit
that referenced
this pull request
Jun 5, 2023
* remove old environment endpoints * implement environments as a resource * fix build after rebase * fix encoding * fix test * registering environent resource routes (#2435) * feature(frontend): enabling environments as resources (#2437) * remove old environment endpoints * implement environments as a resource * fix build after rebase * fix encoding * fix test * registering environent resource routes (#2435) * feature(frontend): enabling environments as resources * feature(frontend): fixing unit tests --------- Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com> Co-authored-by: Sebastian Choren <sebastian.choren@gmail.com> * add instrumentation to resource manager * Update map conversion logic * fix cli tests * fix rebase * fix span name * fix tests * remove broken middleware config * fix generated file * chore(docs): updating docs * feature(cli): enabling environments as resources (#2446) * remove old environment endpoints * feature(frontend): enabling environments as resources (#2437) * remove old environment endpoints * implement environments as a resource * fix build after rebase * fix encoding * fix test * registering environent resource routes (#2435) * feature(frontend): enabling environments as resources * feature(frontend): fixing unit tests --------- Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com> Co-authored-by: Sebastian Choren <sebastian.choren@gmail.com> * fixing unit tests * feature(cli): enabling environments as resources * fixing environments tracetest testing with tracetest * fixing environments tracetest testing with tracetest * fixing environments tracetest testing with tracetest * remove old environment endpoints * implement environments as a resource * fix build after rebase * fix encoding * registering environent resource routes (#2435) * feature(frontend): enabling environments as resources (#2437) * remove old environment endpoints * implement environments as a resource * fix build after rebase * fix encoding * fix test * registering environent resource routes (#2435) * feature(frontend): enabling environments as resources * feature(frontend): fixing unit tests --------- Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com> Co-authored-by: Sebastian Choren <sebastian.choren@gmail.com> * fix rebase * fixing unit tests * fixing environments tracetest testing with tracetest * fixing environments tracetest testing with tracetest * fix rebase * fix test run with env * fix bad rebase --------- Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com> Co-authored-by: Sebastian Choren <sebastian.choren@gmail.com> * fix instrumentation * fix span name * Apply suggestions from code review Co-authored-by: Daniel Baptista Dias <danielbdias@users.noreply.github.com> * remove empty line --------- Co-authored-by: Sebastian Choren <sebastian.choren@gmail.com> Co-authored-by: Oscar Reyes <oscar-rreyes1@hotmail.com> Co-authored-by: Daniel Dias <danielbpdias@gmail.com> Co-authored-by: Daniel Baptista Dias <danielbdias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables environments as resources
Changes
Fixes
Checklist
https://www.loom.com/share/abfa0a6aebb045f69cde8aec5c941737