Fix installer tracetest dev docker warning and add options to run installer directly without user input. #2462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbdias
changed the title
danielbdias
commented
Apr 28, 2023
Comment on lines
+328
to
+330
| Environment: map[string]string{ | ||
| "TRACETEST_DEV": "", | ||
| }, |
There was a problem hiding this comment.
This is the main change of this PR to avoid warnings. We use the same set of tools as docker-compose, which emits a warning on loader.Load even if we are not running the containers.
jorgeepc
approved these changes
May 2, 2023
4 tasks
schoren
pushed a commit
that referenced
this pull request
Jun 5, 2023
…taller directly without user input. (#2462) * Adding options to run installer with previously chosen options * Adding empty TRACETEST_DEV env when loading docker-compose on installation to avoid warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a warning that users receive when trying to install Tracetest with docker (as shown on the image below) and add two optional params to skip user input on
tracetest server install.Changes
docker-composefor the first time to avoid warningFixes
The "TRACETEST_DEV" variable is not set.warning fromtracetest server install#2165Checklist