Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding context flag on server install #2477

Merged
merged 1 commit into from
May 8, 2023

Conversation

danielbdias
Copy link
Contributor

This PR adds a context flag to allow users to bypass the inputs on our CLI.

With that, we can install tracetest on Kubernetes by running the following command:

tracetest server install --run-environment kubernetes --mode with-demo --kubernetes-context docker-desktop

Changes

  • Added kubernetes-context flag on server install command

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Copy link
Collaborator

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we expect this to be part of this release? if so, we'll have to test this A LOT

@danielbdias
Copy link
Contributor Author

Do we expect this to be part of this release? if so, we'll have to test this A LOT

It could be good to have it on the same release as this PR (#2462). What type of tests of you see us doing @xoscar ?

At first glance, I believe that we can expand our Testing guidelines to include installation tests with and without these params.

If needed I can anticipate and at least add some tests in our CI for the docker-compose installer.

@danielbdias danielbdias merged commit dd6c3e1 into main May 8, 2023
29 checks passed
@danielbdias danielbdias deleted the fix/tracetest-kube-installation-with-demo branch May 8, 2023 17:35
schoren pushed a commit that referenced this pull request May 9, 2023
schoren pushed a commit that referenced this pull request Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants