Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): fix automate page to match new run cli command #2928

Merged
merged 2 commits into from Jul 12, 2023
Merged

fix(frontend): fix automate page to match new run cli command #2928

merged 2 commits into from Jul 12, 2023

Conversation

jorgeepc
Copy link
Contributor

@jorgeepc jorgeepc commented Jul 12, 2023 •
edited

This PR updates the Automate test page to match the new CLI run command.

Changes

  • update command to new format (tracetest run test)
  • add run by testID support
  • add skip the result wait support
  • improve selected environment behavior

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom

https://www.loom.com/share/83b55f5db09340f2b524435adff035ed?sid=80514827-3e8c-4771-a95e-e2041fa25c08

@jorgeepc jorgeepc self-assigned this Jul 12, 2023
@jorgeepc jorgeepc marked this pull request as ready for review July 12, 2023 18:27
@jorgeepc jorgeepc requested a review from xoscar July 12, 2023 18:28
schoren
schoren approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@schoren schoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

xoscar
xoscar approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job dude!

@jorgeepc jorgeepc merged commit 7b4e042 into main Jul 12, 2023
25 checks passed
@jorgeepc jorgeepc deleted the 2926-update-automate-page branch July 12, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schoren schoren schoren approved these changes

@xoscar xoscar xoscar approved these changes

Assignees

@jorgeepc jorgeepc

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Automate page to match new run command
3 participants
@jorgeepc @schoren @xoscar