Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): add transaction automate page #2939

Merged
merged 3 commits into from Jul 17, 2023

Conversation

jorgeepc
Copy link
Contributor

@jorgeepc jorgeepc commented Jul 13, 2023

This PR adds the transaction automate page to the transactionRun detail section.

Changes

  • new transaction automate page
  • refactor components to share UI+behavior for tests and transactions

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom

https://www.loom.com/share/4c6dc58fd7bb48daa2ec0d07aa941e26?sid=5a707c44-a90f-4763-a3fb-0fec4799fd89

Screenshot

Screenshot 2023-07-13 at 17 35 06

@jorgeepc jorgeepc self-assigned this Jul 13, 2023
@jorgeepc jorgeepc marked this pull request as ready for review July 13, 2023 22:34
@jorgeepc jorgeepc requested a review from xoscar July 14, 2023 16:59
@jorgeepc jorgeepc force-pushed the feat/add-transaction-automate-page branch from 2b5ffe2 to 0457181 Compare July 14, 2023 17:51
Copy link
Collaborator

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jorgeepc the code looks good, but I'm not sure about having a trigger concept at the transaction level, as technically we are not sending a request like we do for tests 🤔

@jorgeepc
Copy link
Contributor Author

Hey @jorgeepc the code looks good, but I'm not sure about having a trigger concept at the transaction level, as technically we are not sending a request like we do for tests 🤔

@xoscar thanks for the review. We can change that name, maybe something like "Detail"? I was thinking more of the idea that you can still trigger the transaction but I think you are right, we don't have a "Trigger" phase for transactions.

@jorgeepc jorgeepc merged commit b3d0cd8 into main Jul 17, 2023
26 checks passed
@jorgeepc jorgeepc deleted the feat/add-transaction-automate-page branch July 17, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants