feat(agent): docker image #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schoren
reviewed
Sep 26, 2023
agent/Dockerfile
Outdated
| @@ -0,0 +1,7 @@ | |||
| FROM kubeshop/tracetest:v0.13.9 | |||
There was a problem hiding this comment.
this looks like a very easy thing to forget to update on every release. can we make it dynamic somehow?
There was a problem hiding this comment.
do you think it's worth adding it to the pipeline now and make it build the same way our main image?
There was a problem hiding this comment.
yea, totally, no time like the present
danielbdias
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the dockerfile for the agent
Checklist