-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(agent): docker image #3189
Merged
Merged
Changes from 4 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
abe4e06
feat(agent): add docker image based on tracetest
mathnogueira e685f5e
feat: use latest tag
mathnogueira 41ef10c
feat: use latest release
mathnogueira 41f3f86
fix: remove old entrypoint
mathnogueira c5428a3
include github actions
mathnogueira 9a06c76
fix
mathnogueira a087bf1
fix
mathnogueira 519a548
fix
mathnogueira 26dd3de
fix
mathnogueira c83a815
fix
mathnogueira 6337ee5
fix
mathnogueira 64b27cf
fix
mathnogueira 618158e
fix
mathnogueira 58f1ab3
fix
mathnogueira 0612262
remove testing code
mathnogueira File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| FROM kubeshop/tracetest:v0.13.9 | ||
| WORKDIR /app | ||
|
|
||
| ENV TRACETEST_API_KEY "" | ||
|
|
||
| ENTRYPOINT [ "tracetest", "start", "--api-key", "$TRACETEST_API_KEY" ] | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like a very easy thing to forget to update on every release. can we make it dynamic somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think it's worth adding it to the pipeline now and make it build the same way our main image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, totally, no time like the present
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!