Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): configure endpoint priority #3285

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix(cli): configure endpoint priority #3285

merged 1 commit into from
Oct 23, 2023

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Oct 19, 2023

This PR fixes an issue with the configure command not properly switching to the specific provided endpoint from a flag.

Changes

  • Updates the priority list to look at the flag first before the previous UI endpoint

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

https://www.loom.com/share/5ce9c22064314cfeafe8e0b39bd13280

@xoscar xoscar self-assigned this Oct 19, 2023
@xoscar xoscar marked this pull request as ready for review October 19, 2023 19:32
@xoscar xoscar merged commit ed06964 into main Oct 23, 2023
38 checks passed
@xoscar xoscar deleted the fix/configure-endpoint-priority branch October 23, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schoren schoren schoren approved these changes

@jorgeepc jorgeepc jorgeepc approved these changes

@mathnogueira mathnogueira Awaiting requested review from mathnogueira

@danielbdias danielbdias Awaiting requested review from danielbdias

Assignees

@xoscar xoscar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xoscar @schoren @jorgeepc