-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Import Modal #3360
feat: Import Modal #3360
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking gooood!
import {Editor} from 'components/Inputs'; | ||
import {SupportedEditors} from 'constants/Editor.constants'; | ||
|
||
export const FORM_ID = 'create-test'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you are using this 🤔
@@ -45,6 +45,10 @@ const Content = ({triggerType}: IProps) => { | |||
const onValidate = useValidateTestDraft({pluginName: plugin.name, setIsValid}); | |||
const [form] = Form.useForm<TDraftTest>(); | |||
|
|||
useEffect(() => { | |||
onValidate({}, draftTest); | |||
}, []); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing deps?
* feat(frontend): add trigger type modal (#3326) * feat(frontend): decouple test run page (#3338) Co-authored-by: Oscar Reyes <oscar-rreyes1@hotmail.com> * Chore/component cleanup (#3357) chore: component cleanup * feat(frontend): UI updates to test trigger tab (#3354) * feat(frontend): add new ux layout to test edit (#3359) * feat: Import Modal (#3360) * feat: Import Modal * chore: component cleanup * Feat/skip trace collection (#3351) feat(BE): Skip Trace Collection * Feat/skip trace collection 2 (#3353) * feat(BE): Skip Trace Collection * feat(FE): Skip Trace Collection * fix: loading state * feat(frontend): add edit test name form (#3363) * feat(frontend): add edit test name form * fix minor issue with form * Fix/name update (#3366) fix: UX improvements * fix(frontend): fix e2e tests (#3365) * fix(frontend): fix e2e tests * fix * feat: UX improvements * fix: popover state * fix(frontend): add variable set selector (#3380) --------- Co-authored-by: Jorge Padilla <jorge.esteban.padilla@gmail.com>
This PR adds the implementation for the import modal including CURL and Postman
Changes
Fixes
Checklist
Loom video
https://www.loom.com/share/5af20f2fbe924931b2ec8886a61e318c