Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): add variable set selector #3380

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

jorgeepc
Copy link
Contributor

This PR introduces minor fixes for the test creation flow epic.

Changes

  • add variable set selector
  • fix header height to match the run detail layout
  • improve copy

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Screenshot

Screenshot 2023-11-20 at 16 20 54

@jorgeepc jorgeepc self-assigned this Nov 20, 2023
@jorgeepc jorgeepc marked this pull request as ready for review November 20, 2023 21:23
@jorgeepc jorgeepc requested a review from xoscar November 21, 2023 15:12
@jorgeepc jorgeepc merged commit 67d7401 into feat-ux-test-creation Nov 21, 2023
38 checks passed
@jorgeepc jorgeepc deleted the fix-add-var-set-selector branch November 21, 2023 15:35
xoscar added a commit that referenced this pull request Nov 21, 2023
* feat(frontend): add trigger type modal (#3326)

* feat(frontend): decouple test run page (#3338)

Co-authored-by: Oscar Reyes <oscar-rreyes1@hotmail.com>

* Chore/component cleanup (#3357)

chore: component cleanup

* feat(frontend): UI updates to test trigger tab (#3354)

* feat(frontend): add new ux layout to test edit (#3359)

* feat: Import Modal (#3360)

* feat: Import Modal

* chore: component cleanup

* Feat/skip trace collection (#3351)

feat(BE): Skip Trace Collection

* Feat/skip trace collection 2 (#3353)

* feat(BE): Skip Trace Collection

* feat(FE): Skip Trace Collection

* fix: loading state

* feat(frontend): add edit test name form (#3363)

* feat(frontend): add edit test name form

* fix minor issue with form

* Fix/name update (#3366)

fix: UX improvements

* fix(frontend): fix e2e tests (#3365)

* fix(frontend): fix e2e tests

* fix

* feat: UX improvements

* fix: popover state

* fix(frontend): add variable set selector (#3380)

---------

Co-authored-by: Jorge Padilla <jorge.esteban.padilla@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants