Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example(sumologic): edit readme #3529

Merged
merged 2 commits into from Jan 17, 2024
Merged

example(sumologic): edit readme #3529

merged 2 commits into from Jan 17, 2024

Conversation

adnanrahic
Copy link
Contributor

This PR...

Changes

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

Add your loom video here if your work can be visualized

@adnanrahic adnanrahic marked this pull request as ready for review January 16, 2024 16:56
@adnanrahic adnanrahic self-assigned this Jan 16, 2024
jfermi
jfermi reviewed Jan 16, 2024
View reviewed changes
Copy link
Member

@jfermi jfermi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few editing suggestions.

@adnanrahic adnanrahic merged commit 9978afc into main Jan 17, 2024
37 checks passed
@adnanrahic adnanrahic deleted the examples-sumologic-fix-4 branch January 17, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfermi jfermi jfermi left review comments

@jorgeepc jorgeepc jorgeepc approved these changes

@xoscar xoscar xoscar approved these changes

@danielbdias danielbdias danielbdias approved these changes

@kdhamric kdhamric Awaiting requested review from kdhamric

Assignees

@adnanrahic adnanrahic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adnanrahic @jorgeepc @xoscar @danielbdias @jfermi