-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Addon] GitOps addon #411
[Addon] GitOps addon #411
Conversation
@FogDong Draft PR like you suggested. |
Every time you commit, please use |
Sure. I'm sorry about that. It skipped my mind. |
Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>
Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>
Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>
Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>
Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>
Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>
Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>
* Feat: add grafana addon Signed-off-by: Yin Da <yd219913@alibaba-inc.com> * Fix: add dependency test for grafana Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
* wip add clickhouse addon Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com> * add clickhouse addon Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com> * use auto detect Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com> * Add clickhouse addon Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com> * update readme for clickhouse Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>
Hi @FogDong, I will attempt a rebase to update the commit messages I previously did not sign off. |
} | ||
path: parameter.paths.glob | ||
suspend: parameter.suspend | ||
prune: parameter.prune |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these fields the same in the argocd and fluxcd?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, most of them are. I modified the path though. Fluxcd has just parameter.paths
, but I added parameter.paths.glob
so that the user can specify a generic file or folder pattern for system to match. I can change it though.
|
||
template: { | ||
output: { | ||
if parameter.agent == "fluxcd" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest that you can separate the entire CR of fluxcd and argocd with if, not just the apiVersion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I am working on that now.
# Conflicts: # addons/grafana/parameter.cue # addons/grafana/resources/grafana-dashboard-kubevela-system.cue # addons/grafana/resources/grafana-storage.cue # addons/grafana/template.cue # test/e2e-test/addon-test/main.go
Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>
Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>
Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>
Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>
Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>
Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>
Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>
Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>
Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>
Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>
repoURL: parameter.url | ||
targetRevision: HEAD | ||
path: "" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the path from user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It represents the cluster path. 🤔 Thinking about it now, it could or could not be supplied by the user. I can make it user-supplied for more flexibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vela also has the capability of multi-cluster, maybe we can combine them together.
} | ||
|
||
outputs: { // for applications, multiple can be defined | ||
// should I use what is in experimental argocd (application.cue)? It seems like there is a lot of repetition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be the ArgoCD gitops App..
|
||
syncPolicy: { | ||
syncOptions: { | ||
CreateNamespace=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a valid cue? I suppose the agent=argocd
can not work right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet...
Description of your changes
Fixes #3205
How has this code been tested?
Checklist
I have:
[Addon]
,[example]
or[Doc]
).version
inmetadata.yaml
to generate a new version.