[Addon] GitOps addon #411

MimicTester1307 · 2022-07-15T20:13:29Z

Description of your changes

Fixes #3205

How has this code been tested?

Checklist

I have:

Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
Updated/Added any relevant documentation and examples.
New addon should be put in experimental.
Update addon should modify the version in metadata.yaml to generate a new version.
Any changes about verified addons should be tested with CI script.

MimicTester1307 · 2022-07-15T20:16:59Z

@FogDong Draft PR like you suggested.

FogDong · 2022-07-18T03:07:44Z

Every time you commit, please use -s the sign the DCO like git commit -s

MimicTester1307 · 2022-07-18T11:09:58Z

Every time you commit, please use -s the sign the DCO like git commit -s

Sure. I'm sorry about that. It skipped my mind.

Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>

* Feat: add grafana addon Signed-off-by: Yin Da <yd219913@alibaba-inc.com> * Fix: add dependency test for grafana Signed-off-by: Yin Da <yd219913@alibaba-inc.com>

* wip add clickhouse addon Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com> * add clickhouse addon Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com> * use auto detect Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com> * Add clickhouse addon Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com> * update readme for clickhouse Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>

Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>

MimicTester1307 · 2022-07-29T13:02:29Z

Hi @FogDong, I will attempt a rebase to update the commit messages I previously did not sign off.

FogDong · 2022-08-05T03:51:41Z

experimental/addons/gitops/definitions/gitops.cue

+			}
+			path: parameter.paths.glob
+			suspend: parameter.suspend
+			prune: parameter.prune


Are these fields the same in the argocd and fluxcd?

Yes, most of them are. I modified the path though. Fluxcd has just parameter.paths, but I added parameter.paths.glob so that the user can specify a generic file or folder pattern for system to match. I can change it though.

FogDong · 2022-08-08T07:58:02Z

experimental/addons/gitops/definitions/gitops.cue

+
+template: {
+	output: {
+		if parameter.agent == "fluxcd" {


I suggest that you can separate the entire CR of fluxcd and argocd with if, not just the apiVersion.

Sure, I am working on that now.

# Conflicts: # addons/grafana/parameter.cue # addons/grafana/resources/grafana-dashboard-kubevela-system.cue # addons/grafana/resources/grafana-storage.cue # addons/grafana/template.cue # test/e2e-test/addon-test/main.go

Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>

FogDong · 2022-09-13T03:32:33Z

experimental/addons/gitops/definitions/gitops.cue

+							repoURL: parameter.url
+							targetRevision: HEAD
+							path: ""
+						}


Is the path from user?

It represents the cluster path. 🤔 Thinking about it now, it could or could not be supplied by the user. I can make it user-supplied for more flexibility?

Vela also has the capability of multi-cluster, maybe we can combine them together.

FogDong · 2022-09-13T03:34:09Z

experimental/addons/gitops/definitions/gitops.cue

+			}
+
+			outputs: {  // for applications, multiple can be defined
+				// should I use what is in experimental argocd (application.cue)? It seems like there is a lot of repetition


This should be the ArgoCD gitops App..

FogDong · 2022-09-13T03:34:40Z

experimental/addons/gitops/definitions/gitops.cue

+
+						syncPolicy: {
+							syncOptions: {
+								CreateNamespace=true


Is this a valid cue? I suppose the agent=argocd can not work right now.

MimicTester1307 and others added 2 commits July 13, 2022 19:13

First commit: create directory structure

3b12a7b

Merge branch 'kubevela:master' into master

a4c9545

MimicTester1307 and others added 4 commits July 19, 2022 14:34

Merge branch 'kubevela:master' into master

e8f6beb

Merge branch 'kubevela:master' into master

50464d1

Merge branch 'kubevela:master' into master

f5ff3ec

create gitops definition file

97846c1

MimicTester1307 changed the title ~~Feat: Implement GitOps addon~~ [Addon] GitOps addon Jul 28, 2022

MimicTester1307 and others added 12 commits July 28, 2022 18:59

include definitions for metadata and template files

79b774a

Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>

create separate file for definition parameters

1c2511f

Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>

rename tool to agent

8bf3138

Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>

remove spec definition

e6c2d0a

Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>

define some parameters for addon

cd040fc

Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>

define single output for gitops cue file

748a69e

Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>

Merge branch 'kubevela:master' into master

e3660a4

Merge remote-tracking branch 'origin/master'

84464bc

refactor gitops repo from addons to experimental/addons

d6cf49f

Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>

[Addon] grafana addon (kubevela#428)

2dc9af1

* Feat: add grafana addon Signed-off-by: Yin Da <yd219913@alibaba-inc.com> * Fix: add dependency test for grafana Signed-off-by: Yin Da <yd219913@alibaba-inc.com>

refactor gitops repo from addons to experimental/addons

9d672c6

Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>

Merge branch 'kubevela:master' into master

8244655

FogDong reviewed Aug 5, 2022

View reviewed changes

FogDong reviewed Aug 8, 2022

View reviewed changes

MimicTester1307 and others added 4 commits August 9, 2022 12:21

Merge branch 'kubevela:master' into master

04ca21c

Merge remote-tracking branch 'origin/master'

7062581

# Conflicts: # addons/grafana/parameter.cue # addons/grafana/resources/grafana-dashboard-kubevela-system.cue # addons/grafana/resources/grafana-storage.cue # addons/grafana/template.cue # test/e2e-test/addon-test/main.go

move parameters to template field and delete parameter.cue file

0d05038

Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>

update gitops.cue file with parameters

1009dac

Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>

MimicTester1307 and others added 13 commits August 10, 2022 14:19

remove metadata.name in template

ca4743c

Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>

remove needNamespace field

ccc282f

Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>

use condition statement to check for entire component definition

eca7c10

Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>

Merge branch 'kubevela:master' into master

cbc29ef

Merge branch 'kubevela:master' into master

6c02385

update readme for addon.

ae5d46e

Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>

update fluxcd agent and add implementation for argocd

87a9b52

Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>

Merge remote-tracking branch 'origin/master'

b4312e5

update definitions for argocd

bf8377e

Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>

include dependencies for addon

757cf5b

Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>

add core-install yaml file for argocd

ee05c54

Signed-off-by: MimicTester1307 <excel.chukwu@ashesi.edu.gh>

Merge branch 'kubevela:master' into master

e5e2c25

Merge remote-tracking branch 'origin/master'

dea6cd4

FogDong reviewed Sep 13, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Addon] GitOps addon #411

[Addon] GitOps addon #411

MimicTester1307 commented Jul 15, 2022 •

edited

MimicTester1307 commented Jul 15, 2022

FogDong commented Jul 18, 2022

MimicTester1307 commented Jul 18, 2022 •

edited

MimicTester1307 commented Jul 29, 2022 •

edited

FogDong Aug 5, 2022

MimicTester1307 Aug 5, 2022

FogDong Aug 8, 2022

MimicTester1307 Aug 9, 2022

FogDong Sep 13, 2022 •

edited

MimicTester1307 Sep 15, 2022

FogDong Sep 15, 2022 •

edited

FogDong Sep 13, 2022

FogDong Sep 13, 2022

MimicTester1307 Sep 15, 2022

[Addon] GitOps addon #411

Are you sure you want to change the base?

[Addon] GitOps addon #411

Conversation

MimicTester1307 commented Jul 15, 2022 • edited

Description of your changes

How has this code been tested?

Checklist

MimicTester1307 commented Jul 15, 2022

FogDong commented Jul 18, 2022

MimicTester1307 commented Jul 18, 2022 • edited

MimicTester1307 commented Jul 29, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FogDong Sep 13, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FogDong Sep 15, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MimicTester1307 commented Jul 15, 2022 •

edited

MimicTester1307 commented Jul 18, 2022 •

edited

MimicTester1307 commented Jul 29, 2022 •

edited

FogDong Sep 13, 2022 •

edited

FogDong Sep 15, 2022 •

edited