Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the top banner to reference version 1.9.0 release notes #1273

Merged
merged 4 commits into from
Aug 17, 2023

Conversation

anoop2811
Copy link
Contributor

@anoop2811 anoop2811 commented Aug 16, 2023

Description of your changes

I have:

  • Read and followed KubeVela's contribution process.
  • Update sidebar.js if adding a new page.
  • Run yarn start to ensure the changes has taken effect.

Special notes for your reviewer

@wonderflow @chivalryq : We updated the top banner to show 1.9.0 instead of 1.8.0. However as we speak the latest release is 1.9.6, so the question is should we point to that instead? The reason we pointed to 1.9.0 was because it had the most release notes of relevance for people moving from 1.8.0 but we are happy to change and point to 1.9.6 if needed.

anoop2811 and others added 4 commits July 14, 2023 08:24
Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in>
 - Also ran the `make update-version version=v1.9`
 - Fixes kubevela#1272

Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in>
Copy link
Member

@chivalryq chivalryq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to point to release 1.9.0 because the release note is more detailed. And that's what we do in "Next" section of document. Now this PR looks good to me.

@chivalryq chivalryq merged commit 202d0ea into kubevela:main Aug 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants