Docs: add annotations reference doc #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let users know how to configure annotations for the Application. Refs kubevela/kubevela#3434 Signed-off-by: Sunghoon Kang <hoon@linecorp.com>
4 tasks
wonderflow
reviewed
Mar 15, 2022
docs/end-user/annotations.md
Outdated
| @@ -0,0 +1,17 @@ | |||
| --- | |||
| title: Annotations | |||
There was a problem hiding this comment.
Suggested change
| title: Annotations | |
| title: Service Account Integration |
There was a problem hiding this comment.
Annotation may be not clear enough for this feature and users can hardly find the docs.
I think we can just clarify the service account mechanism here and tell users how to use it. Give some examples.
There was a problem hiding this comment.
Thanks for the feedback. I added an example and background to the document. Could you re-review?
kubevela#542 (review) Signed-off-by: Sunghoon Kang <hoon@linecorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let users know how to configure annotations for the Application.
Refs kubevela/kubevela#3434
Signed-off-by: Sunghoon Kang hoon@linecorp.com
Notes
Should not be merged before kubevela/kubevela#3434 got merged