Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Enable custom component revisioning to support consistent versioning across clusters #2620

Open
anoop2811 opened this issue Nov 4, 2021 · 2 comments

Comments

@anoop2811
Copy link
Contributor

Is your feature request related to a problem? Please describe.
ComponentDefinition revisioning is currently auto generated and this poses a problem where the version may not be the same across clusters. When we pin a version to a component instance, it will need to be updated to reflect the ComponentDefinition version in that cluster. This means that the workflow files that the app developers write will have to target each cluster separately which may not be feasible if we have a large number of clusters with different deployment/maintenance windows

Describe the solution you'd like
The ability to use a custom revision with semantic versioning will give the app developer both the scope of changes in the ComponentDefinition as well as to pin to a more synchronized version number.
Describe alternatives you've considered
If component revision is not able to be customized, maybe allow a extra revision label which could be referred in the component instance

@anoop2811
Copy link
Contributor Author

anoop2811 commented Nov 4, 2021

An example of Component Definition could be:

   apiVersion: core.oam.dev/v1beta1
   kind: ComponentDefinition
   metadata:
     name: webservice
     namespace: default
     revision: 1.1
     revisionChangeLog: https://github.com/example/changelog-1.1.md
     annotations:
       definition.oam.dev/description: "Describes long-running, scalable, containerized services that have a stable network endpoint to receive external network traffic from customers."
   spec:
     workload:
       definition:
         apiVersion: apps/v1
         kind: Deployment 

@wonderflow
Copy link
Collaborator

ref #3573

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants