Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Can't load the category of the workflow step definition. #702

Closed
barnettZQG opened this issue Mar 15, 2023 · 1 comment · Fixed by #711
Closed

[BUG] Can't load the category of the workflow step definition. #702

barnettZQG opened this issue Mar 15, 2023 · 1 comment · Fixed by #711
Assignees
@NeerajGartia21
Labels
kind/bug Something isn't working
Milestone
1.8

Comments

@barnettZQG
Copy link
Collaborator

barnettZQG commented Mar 15, 2023 •
edited
Loading

Describe the bug

Now, Frontend loads the step category from the label definition.oam.dev/catalog. But all step definitions define the category by the label custom.definition.oam.dev/category. Refer to this PR change It's not matched.

image

So, we need to change the frontend code. The path is packages/velaux-ui/src/components/WorkflowStudio/type-select.tsx
@barnettZQG barnettZQG added the kind/bug Something isn't working label Mar 15, 2023
@barnettZQG barnettZQG added this to the 1.8 milestone Mar 15, 2023
@NeerajGartia21
Copy link
Collaborator

Can you please assign it to me?

@NeerajGartia21 NeerajGartia21 mentioned this issue Mar 20, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NeerajGartia21 NeerajGartia21

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
1.8
Development

Successfully merging a pull request may close this issue.

Fix: Load the category of the workflow step definition.
2 participants
@barnettZQG @NeerajGartia21