Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add MySQL database driver #825

Merged
merged 5 commits into from
Jun 9, 2023

Conversation

NeerajGartia21
Copy link
Collaborator

Description of your changes

This PR adds MySQL driver for the VelaUX api-server

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (0ad6d36) 61.13% compared to head (d5554a7) 61.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #825      +/-   ##
==========================================
- Coverage   61.13%   61.09%   -0.04%     
==========================================
  Files         109      110       +1     
  Lines       19143    19174      +31     
==========================================
+ Hits        11703    11715      +12     
- Misses       5989     6011      +22     
+ Partials     1451     1448       -3     
Flag Coverage Δ
apiserver-unittests 33.72% <ø> (-0.10%) ⬇️
server-e2e-tests 49.79% <0.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/server/infrastructure/datastore/mysql/mysql.go 0.00% <0.00%> (ø)
pkg/server/server.go 54.54% <0.00%> (-0.84%) ⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
@chivalryq
Copy link
Member

Please fix the static check CI and rebase after this is merged: #826

NeerajGartia21 and others added 2 commits May 22, 2023 07:19
Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
@NeerajGartia21 NeerajGartia21 marked this pull request as ready for review May 22, 2023 02:40
@NeerajGartia21
Copy link
Collaborator Author

Done @chivalryq !

Copy link
Member

@chivalryq chivalryq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chivalryq chivalryq merged commit c01aa00 into kubevela:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants