Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: server test fails for k3d version #826

Merged
merged 3 commits into from
May 22, 2023

Conversation

chivalryq
Copy link
Member

@chivalryq chivalryq commented May 21, 2023

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.07 🎉

Comparison is base (c55b911) 61.10% compared to head (f9882db) 61.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #826      +/-   ##
==========================================
+ Coverage   61.10%   61.17%   +0.07%     
==========================================
  Files         109      109              
  Lines       19143    19143              
==========================================
+ Hits        11697    11711      +14     
+ Misses       5995     5985      -10     
+ Partials     1451     1447       -4     
Flag Coverage Δ
apiserver-unittests 33.76% <ø> (+0.06%) ⬆️
server-e2e-tests 49.76% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
@barnettZQG barnettZQG merged commit 0ad6d36 into kubevela:main May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants