-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multus bump script #456
Conversation
/hold until #449 is merged |
4e26410
to
84dc168
Compare
84dc168
to
9fd721b
Compare
9fd721b
to
1a12af9
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
Can we also fetch Multus manifests?
1a12af9
to
0b52e06
Compare
I think we can use the image yaml with some kustomize/sed tweeks Though I didn't undersatnd why they have 2 multus daemonsets there |
/lgtm |
59cd5d0
to
14bd37d
Compare
/lgtm |
/retest |
/hold need to resolve the |
14bd37d
to
c373f26
Compare
/unhold |
/lgtm |
/retest unrelated flakyness |
/retest |
/hold There is a real issue:
Seems that the new version of the DaemonSet changes label selectors. We are not allowed to patch that live. |
Signed-off-by: Ram Lavi <ralavi@redhat.com>
c373f26
to
449f48e
Compare
From some reason it doesn't recreate in my local, but I changed it as the error is very specific. Let's see if this solves the issue |
/hold |
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: phoracek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Currently cnao only bumps multus manually.
Let's add a script to do it for us.
Special notes for your reviewer:
Release note: