Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint errors #767

Merged
merged 3 commits into from
Aug 23, 2021
Merged

Conversation

tylerauerbeck
Copy link
Contributor

Signed-off-by: Tyler Auerbeck tauerbec@redhat.com

What this PR does / why we need it:

This PR will fix the initial lint errors found by make check_lint

Does this PR fix any issue? (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #766

Special notes for your reviewer:

Starting this off as a draft as it will likely grow quite large.

Signed-off-by: Tyler Auerbeck <tauerbec@redhat.com>
@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 22, 2021
@kubevirt-bot
Copy link
Contributor

Hi @tylerauerbeck. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhiller
Copy link
Contributor

dhiller commented Jul 22, 2021

/test all

@dhiller
Copy link
Contributor

dhiller commented Jul 22, 2021

@tylerauerbeck I'll be offline for a while now, so to be fair, I'll remove myself from the reviewers list.

@dhiller dhiller removed their request for review July 22, 2021 08:35
Signed-off-by: Tyler Auerbeck <tauerbec@redhat.com>
@kubevirt-bot kubevirt-bot added size/XL kind/blog Label for blog entries and removed size/L labels Jul 24, 2021
…osts

Signed-off-by: Tyler Auerbeck <tauerbec@redhat.com>
@tylerauerbeck tylerauerbeck marked this pull request as ready for review July 24, 2021 15:43
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2021
@tylerauerbeck
Copy link
Contributor Author

This should be ready now. There are a handful of lint rules that I had disabled for now and I added two _includes files to the .markdownlintignore file as there are conflicts with how they get included vs lint rules that you would want in place in other files. But otherwise, this is just a bunch of fixes to correct the lint errors.

Copy link
Member

@cwilkers cwilkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still working on gaining reviewer/approver access, but overall, this looks good to me.
The one comment I made was about a seemingly spurious anchor that made its way in, and I don't think it will affect the overall flow as long as lint doesn't seem to care.


> error ""
> Be aware of the costs of associated with using infrastructure provided by cloud computing providers.
<a/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this bare anchor necessary? It wasn't there before and doesn't seem to match up with the rest of the document

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly, this was because there was contradicting linting rules. So my workaround was to add this empty anchor. Let me take a look back at this and remove it to see if I can work this out.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2021
@cwilkers
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cwilkers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2021
@kubevirt-bot kubevirt-bot merged commit 62284f5 into kubevirt:master Aug 23, 2021
@mazzystr
Copy link
Contributor

@tylerauerbeck Wow! Thanks for this clean up effort!

@mazzystr mazzystr added kind/enhancement and removed kind/blog Label for blog entries labels Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/enhancement lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix current lint issues in markdown files
5 participants