-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lint errors #767
Fix lint errors #767
Conversation
Signed-off-by: Tyler Auerbeck <tauerbec@redhat.com>
Hi @tylerauerbeck. Thanks for your PR. I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test all |
@tylerauerbeck I'll be offline for a while now, so to be fair, I'll remove myself from the reviewers list. |
Signed-off-by: Tyler Auerbeck <tauerbec@redhat.com>
…osts Signed-off-by: Tyler Auerbeck <tauerbec@redhat.com>
This should be ready now. There are a handful of lint rules that I had disabled for now and I added two _includes files to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still working on gaining reviewer/approver access, but overall, this looks good to me.
The one comment I made was about a seemingly spurious anchor that made its way in, and I don't think it will affect the overall flow as long as lint doesn't seem to care.
|
||
> error "" | ||
> Be aware of the costs of associated with using infrastructure provided by cloud computing providers. | ||
<a/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this bare anchor necessary? It wasn't there before and doesn't seem to match up with the rest of the document
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly, this was because there was contradicting linting rules. So my workaround was to add this empty anchor. Let me take a look back at this and remove it to see if I can work this out.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cwilkers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tylerauerbeck Wow! Thanks for this clean up effort! |
Signed-off-by: Tyler Auerbeck tauerbec@redhat.com
What this PR does / why we need it:
This PR will fix the initial lint errors found by
make check_lint
Does this PR fix any issue? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #766
Special notes for your reviewer:
Starting this off as a draft as it will likely grow quite large.