-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable building and running kubevirt on s390x #10490
Conversation
Hi @jschintag. Thanks for your PR. I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Starting point to splitting this into multiple smaller PRs is to generate issues for the parts that can be upstreamed relatively independently of each other, e.g:
|
@cfilleke @jschintag please take into account that we'll need also CI integration. Please, take a look to the kubevirtci and project-infra. The CI needs to be integrated in prow and KVM capable. Ideally, the CI host shouldn't be z/VM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jschintag the bulk of the changes to the Go code look sane, but I have some concerns around the build system situation.
As a "meta" comment, I understand that this is a WIP, but I still think it would be great if you could reorganize things a bit to make reviewers' lives easier. As it is today, there are things that are introduced halfway through the series only to be ripped out later, bits that are iterated over multiple times... It just makes things more confusing that they need to be IMO.
Rebasing on top of main
would also be great: at this point, it has diverged quite a bit from the base of your branch.
@andreabolognani Thank you for your review. I am currently working on squashing all the commits into something more presentable, and i will also rebase it as part of that. If i don't run into errors with the rebase, i will have that done this week. My goal with this PR was mainly to raise awareness about our effort and get early feedback. I think your preference would be to have CI first, before merging the code. Is that correct? |
e92e0a1
to
2f1145f
Compare
The new version looks a lot more manageable already, thanks! Looking forward to the rebased one :)
Not my call to make, so I'll let someone else answer :) |
I would strongly encourage you to concentrate on the CI. It might take some time and I would say it is a must before merging something. For the SEV support, the PR was blocked for several months even if the code was ready because we were lacking the CI. /cc @brianmcarey @dhiller |
2f1145f
to
16eef33
Compare
I pushed the rebase, but so far it has at the least broken virt-handler, so i will have to look at fixing it. @alicefr For the CI work, my colleagues are working on it in parallel. |
@jschintag can you please explain the purpose of the |
The rebase looks sane by the way, I'm surprised that virt-handler would no longer work after it but I'm sure you'll figure out the reason :) |
16eef33
to
7f05290
Compare
@jschintag please at least improve the comment as requested here since you're going to need to rebase anyway. /lgtm |
Hello reviewers, We are not able to rebase this PR due to the unavailability of the @jschintag . So, I have raised this new #12066 PR with the same changes by rebasing with the latest changes and addressing this comment. #10490 (comment) |
Add s390x container select statements. Enable s390x virtctl builds. Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com>
Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com>
Add explanation on how to onboard new arches with the new bazel sandbox mechanic in place. Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com>
Skip cirros and fedora-with-test-tooling, as they are not build for s390x. Skip images needed for e2e tests. Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com>
Refactor if-else for selecting the right architecture code to switch-case. Ensure arm64 specific cases are more clearly recognizable as such. Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com>
Add s390x Machine Type. Enable and add IsS390X functions. Set default disk type as virtio for s390x. Disable ROM tuning on s390x. Disable USB on s390x. Set device model to virtio instead of none for ccw devices. Do not set virtio-(non)-transitional model type for ccw devices. Add s390x to supported architectures in node-labeller. Use default CPU mode implementation for s390x. Disable ACPI Feature by default on s390x. Disable usbredir for s390x. Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com>
The virtctl version unit test depends on the version information being injected during the compile step. This does not happen when running it via `make go-test`. Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com>
I'm back from vacation and i have rebased the PR. Additionally i have added the requested extended comment. Thank you for your review and sorry that i did not give push rights before leaving for vacation. I thought a single week wouldn't make that much of a difference... |
/lgtm |
Required labels detected, running phase 2 presubmits: |
I could build and deploy the PR on s390x without problems. Unit tests also passed. |
/test pull-kubevirt-e2e-k8s-1.30-sig-storage |
/lgtm |
@jschintag congrats! 👏 |
What this PR does / why we need it:
Enable building and running kubevirt on IBM Z Platform.
The Purpose of this Draft PR is not to merge it as is, but rather have a discussion about the Changes and start gathering Feedback from the community.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Since this is a WIP PR, here are my open TODOs for the PR:
TODOs:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: