Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FOSSA issues #2796

Closed
wants to merge 1 commit into from
Closed

Fix FOSSA issues #2796

wants to merge 1 commit into from

Conversation

dhiller
Copy link
Contributor

@dhiller dhiller commented Oct 9, 2019 •
edited
Loading

What this PR does / why we need it:
Fixes FOSSA licensing issues brought up here

Closes #2789

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Fix FOSSA licensing issues

@kubevirt-bot
Copy link
Contributor

@dhiller: GitHub didn't allow me to request PR reviews from the following users: dhiller.

Note that only kubevirt members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Signed-off-by: Daniel Hiller daniel.hiller.1972@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

/cc @dhiller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XXL labels Oct 9, 2019
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fabiand
You can assign the PR to them by writing /assign @fabiand in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 9, 2019
This was referenced Oct 9, 2019
Closed
Closed
@dhiller dhiller force-pushed the fix-fossa-issues branch 2 times, most recently from af9e466 to f69abb5 Compare October 9, 2019 15:46
@dhiller
Fix case of k8snetworkplumbing dependency
2940485 
URL for dependency
github.com/K8sNetworkPlumbingWG/network-attachment-definition-client
was included in all lower case which effectively prohibited updating.
Converted to right case as importing is case sensitive.
https://github.com/golang/go/wiki/Modules#avoid-breaking-existing-import-paths

Signed-off-by: Daniel Hiller <daniel.hiller.1972@gmail.com>
@kubevirt-bot
Copy link
Contributor

@dhiller: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubevirt-e2e-os-3.11.0-multus 2940485 link /test pull-kubevirt-e2e-os-3.11.0-multus
pull-kubevirt-e2e-os-3.11.0-crio 2940485 link /test pull-kubevirt-e2e-os-3.11.0-crio
pull-kubevirt-e2e-kind-k8s-sriov-1.14.2 2940485 link /test pull-kubevirt-e2e-kind-k8s-sriov-1.14.2
pull-kubevirt-e2e-k8s-1.15.1-ceph 2940485 link /test pull-kubevirt-e2e-k8s-1.15.1-ceph
pull-kubevirt-e2e-os-3.11.0 2940485 link /test pull-kubevirt-e2e-os-3.11.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubevirt-bot
Copy link
Contributor

@dhiller: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2019
@dhiller dhiller closed this Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhiller @kubevirt-bot