Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support single stack IPv6 #7158

Merged
merged 9 commits into from Mar 11, 2022
Merged

Conversation

AlonaKaplan
Copy link
Member

@AlonaKaplan AlonaKaplan commented Jan 31, 2022

What this PR does / why we need it:
Add masquerade VMs support to single stack IPv6.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Follow ups

This is a part of #6732.

Release note:

Add masquerade VMs support to single stack IPv6.

@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 31, 2022
@AlonaKaplan
Copy link
Member Author

/test pull-kubevirt-e2e-k8s-1.22-ipv6-sig-network

@AlonaKaplan
Copy link
Member Author

/test pull-kubevirt-e2e-k8s-1.22-ipv6-sig-network

@AlonaKaplan
Copy link
Member Author

/test pull-kubevirt-e2e-k8s-1.22-ipv6-sig-network

@AlonaKaplan AlonaKaplan force-pushed the single_stack_ipv6 branch 2 times, most recently from 4b9dac3 to be5d739 Compare February 6, 2022 12:03
@AlonaKaplan
Copy link
Member Author

/test pull-kubevirt-e2e-k8s-1.22-ipv6-sig-network

@AlonaKaplan
Copy link
Member Author

/test pull-kubevirt-e2e-k8s-1.22-ipv6-sig-network

@AlonaKaplan
Copy link
Member Author

/test pull-kubevirt-e2e-k8s-1.22-ipv6-sig-network

@AlonaKaplan
Copy link
Member Author

/test pull-kubevirt-e2e-k8s-1.22-ipv6-sig-network

@AlonaKaplan
Copy link
Member Author

/test pull-kubevirt-e2e-k8s-1.22-ipv6-sig-network

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 14, 2022
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 9, 2022
@kubevirt-bot kubevirt-bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 10, 2022
- iptables/nftables
- k6t-eth0 bridge gateway
- dhcp configutation

Signed-off-by: Alona Kaplan <alkaplan@redhat.com>
Add single stack ipv6 unit tests to masquerade.

Signed-off-by: Alona Kaplan <alkaplan@redhat.com>
Skip ipv4 tests for cluster with no ipv4.
Skip ipv6 tests for cluster with no ipv6.
Skip dual stack test for cluster that doesn't support both ipv4 and ipv6.

Signed-off-by: Alona Kaplan <alkaplan@redhat.com>
Skip tests that are not supported until RA is introduced -
issue- kubevirt#7184

Signed-off-by: Alona Kaplan <alkaplan@redhat.com>
skip-dual-stack-test flag shoud be true in single stack ipv6 cluster.

Signed-off-by: Alona Kaplan <alkaplan@redhat.com>
The login is taking a bit longer since discovering ipv4 address fails
and it takes a ~minute until the discovery gives up.
Using cloud-init-nocloud userdata to turn off dhcp on eth0 interface
doesn't help to solve the issue since the usedata is invoked after the
networking.
cloudinit NetworkData or metadata.network-interfaces doesn't help as well,
since it is not properly working on cirros.

This is a temporary solution. A follow-up solution will be to use alpine
instead of cirros.

Signed-off-by: Alona Kaplan <alkaplan@redhat.com>
Till now, our tests assumes ipv4 is always supported.
Now that we support single stack ipv6 this assumption is wrong.

This commit fixes the tests to run ipv4 tests only if ipv4 is supported by
the cluster.

Signed-off-by: Alona Kaplan <alkaplan@redhat.com>
Change the tests to test both ipv4 and ipv6.
Skip the ipv6 tests since VM port-forwarding over ipv6 is not supported
yet.
Tracking issue kubevirt#7276


Signed-off-by: Alona Kaplan <alkaplan@redhat.com>
@AlonaKaplan
Copy link
Member Author

/retest

ipv6 support is in alpha stage on Istio u/s and is not supported yet
by kubevirt.

Note: even once ipv6 will be fully supported by istio, kubevirt may have
troubles to make it work for VMs because there is no IPv6 equialent to
"sysctl net.ipv4.conf.all.route_localnet".

Signed-off-by: Alona Kaplan <alkaplan@redhat.com>
@qinqon
Copy link
Contributor

qinqon commented Mar 10, 2022

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2022
@AlonaKaplan
Copy link
Member Author

/retest

@kubevirt-bot kubevirt-bot merged commit b2eb686 into kubevirt:main Mar 11, 2022
fossedihelm added a commit to fossedihelm/project-infra that referenced this pull request Mar 28, 2022
Release 0.50 does not contain single stack IPv6 support that was added to kubevirt here kubevirt/kubevirt#7158

Signed-off-by: fossedihelm <ffossemo@redhat.com>
kubevirt-bot pushed a commit to kubevirt/project-infra that referenced this pull request Mar 28, 2022
Release 0.50 does not contain single stack IPv6 support that was added to kubevirt here kubevirt/kubevirt#7158

Signed-off-by: fossedihelm <ffossemo@redhat.com>
AlonaKaplan added a commit to AlonaKaplan/project-infra that referenced this pull request Mar 30, 2022
Release 0.51 does not contain single stack IPv6 support that was added to
kubevirt here kubevirt/kubevirt#7158

Signed-off-by: Alona Kaplan <alkaplan@redhat.com>
kubevirt-bot pushed a commit to kubevirt/project-infra that referenced this pull request Apr 1, 2022
…#2001)

Release 0.51 does not contain single stack IPv6 support that was added to
kubevirt here kubevirt/kubevirt#7158

Signed-off-by: Alona Kaplan <alkaplan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants