Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release 0.51] IPv6 lane shouldn't be required and should be optional #2001

Merged
merged 1 commit into from
Apr 1, 2022
Merged

[Release 0.51] IPv6 lane shouldn't be required and should be optional #2001

merged 1 commit into from
Apr 1, 2022

Conversation

AlonaKaplan
Copy link
Member

Release 0.51 does not contain single stack IPv6 support that was added to
kubevirt here kubevirt/kubevirt#7158

@AlonaKaplan
[Release 0.51] IPv6 lane shouldn't be required and should be optional
da2327f 
Release 0.51 does not contain single stack IPv6 support that was added to
kubevirt here kubevirt/kubevirt#7158

Signed-off-by: Alona Kaplan <alkaplan@redhat.com>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Mar 30, 2022
@kubevirt-bot
Copy link
Contributor

@AlonaKaplan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-project-infra-check-testgrid-config da2327f link false /test pull-project-infra-check-testgrid-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

maiqueb
maiqueb reviewed Mar 31, 2022
View reviewed changes
Copy link
Contributor

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a dual stack ipv6 lane then ?

@AlonaKaplan
Copy link
Member Author

Is there a dual stack ipv6 lane then ?

Besides this single stack ipv6 lane that leaked to 0.51 release by mistake, all our lanes are dual stack.

@maiqueb
Copy link
Contributor

maiqueb commented Mar 31, 2022

Is there a dual stack ipv6 lane then ?

Besides this single stack ipv6 lane that leaked to 0.51 release by mistake, all our lanes are dual stack.

Good to know.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2022
dhiller
dhiller reviewed Apr 1, 2022
View reviewed changes
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2022
@kubevirt-bot kubevirt-bot merged commit 2dfa09f into kubevirt:main Apr 1, 2022
@kubevirt-bot
Copy link
Contributor

@AlonaKaplan: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key kubevirt-presubmits-0.51.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-presubmits-0.51.yaml

In response to this:

Release 0.51 does not contain single stack IPv6 support that was added to
kubevirt here kubevirt/kubevirt#7158

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhiller dhiller dhiller left review comments

@maiqueb maiqueb maiqueb approved these changes

@marceloamaral marceloamaral Awaiting requested review from marceloamaral

Assignees

@maiqueb maiqueb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AlonaKaplan @kubevirt-bot @maiqueb @dhiller