-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-0.58] Patching node set kubevirt.io/schedulable to false upon exiting heartbeat #8790
[release-0.58] Patching node set kubevirt.io/schedulable to false upon exiting heartbeat #8790
Conversation
…beat func This addresses an issue in which making master nodes schedulable and then unschedulable results in a mismatch between the daemonset state and the pods state, with the master nodes still showing up as schedulable. Signed-off-by: prnaraya <prnaraya@redhat.com>
This is to address any potential flakiness caused by the controller shutting down first, to ensure the heartbeat will always mark itself unschedulable before shutdown. Signed-off-by: prnaraya <prnaraya@redhat.com>
Signed-off-by: prnaraya <prnaraya@redhat.com>
/lgtm |
/retest-required |
2 similar comments
/retest-required |
/retest-required |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xpivarc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
1 similar comment
/retest-required |
This is an automated cherry-pick of #8238
/assign acardace